Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to froide #456

Open
11 of 44 tasks
stefanw opened this issue Aug 13, 2021 · 0 comments
Open
11 of 44 tasks

Add typing to froide #456

stefanw opened this issue Aug 13, 2021 · 0 comments

Comments

@stefanw
Copy link
Member

stefanw commented Aug 13, 2021

Use monkeytype to infer types for modules and review:

# Run tests with monkeytype to generate SQLite db of types
monkeytype run manage.py test froide --keepdb
# List modules with type information
monkeytype list-modules
# Apply module
monkeytype apply <froide.module.path>

Review changes, adjust, commit to main and check off below.

  • froide.accesstoken
  • froide.account
  • froide.bounce
  • froide.campaign
  • froide.comments
  • froide.document
  • froide.foirequest
  • froide.foirequestfollower
  • froide.foisite
  • froide.frontpage
  • froide.guide
  • froide.helper.admin_utils
  • froide.helper.api_utils
  • froide.helper.auth
  • froide.helper.cache
  • froide.helper.content_urls
  • froide.helper.context_processors
  • froide.helper.csv_utils
  • froide.helper.date_utils
  • froide.helper.db_utils
  • froide.helper.email_parsing
  • froide.helper.email_sending
  • froide.helper.email_utils
  • froide.helper.feed_utils
  • froide.helper.form_utils
  • froide.helper.forms
  • froide.helper.search
  • froide.helper.spam
  • froide.helper.storage
  • froide.helper.tasks
  • froide.helper.templatetags
  • froide.helper.tests
  • froide.helper.text_diff
  • froide.helper.text_utils
  • froide.helper.utils
  • froide.helper.widgets
  • froide.letter.models
  • froide.problem
  • froide.publicbody
  • froide.settings
  • froide.team
  • froide.tests
  • froide.upload
  • froide.urls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant