Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing integration test sp_guarulhos #126

Conversation

rqclima
Copy link
Contributor

@rqclima rqclima commented Nov 6, 2018

sp_guarulhos integration test was failing, it seems that the available gazettes in that month had changed from 17 to 16.

@rennerocha
Copy link
Member

For most of the spiders that I saw the contract failing, the solution was to fix just the contract, not the spider code. I don't see that this kind of test is useful and I'd suggest that we stop using contracts this way and maybe thinking in different ways of monitoring the results.

@rqclima
Copy link
Contributor Author

rqclima commented Nov 7, 2018

It would be really nice if we can find some other way of monitoring the sanity of these spiders. These tests are really fragile (the spiders are, as the sites can change anytime without notice). And some of the tests look for different data every day, making them even more fragile.

Anyway, it at least tests an important part of the code. And right now it's failing, so I just thought of getting it working again, and then we can think of improving it.

@jvanz jvanz changed the base branch from master to main August 12, 2020 01:36
@rennerocha
Copy link
Member

Contracts on spiders were removed in 3eaeba4 . Discussion related: #44
As we are not using contracts, this PR is not needed anymore.

@rennerocha rennerocha closed this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants