force headers to be str in flask response for login #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mod_wsgi expects response headers to be byte strings and fails with a TypeError as the headers seem to automagically get converted to unicode
joetsoi
added a commit
that referenced
this pull request
Oct 16, 2013
force headers to be str in flask response for login
amercader
added a commit
that referenced
this pull request
Jan 24, 2014
Same situation as in #13, but with the headers returned when there is an exception, eg malformed JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without explicity forcing the response headers to be str types, I get 500 a error (logs show aTypeError: expected byte string object for header name, value of type unicode found) when attempting to use the login view/page with apache/mod_wsgi. Each time you declare a string in the login view it becomes a unicode string, I'm guessing this is a werkzeug/flask thing, but I must admit, I don't really know why this happens.