Skip to content

Commit

Permalink
[#2939] Clean logic auth tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@tobes
tobes committed Nov 19, 2012
1 parent f114c2d commit 120149b
Showing 1 changed file with 27 additions and 27 deletions.
54 changes: 27 additions & 27 deletions ckan/tests/logic/test_auth.py
View file
Expand Up @@ -80,21 +80,21 @@ def test_02_create_orgs(self):
def test_03_create_dataset_no_org(self):

dataset = {'name': 'admin_create_no_org'}
res = self._action_post('package_create', dataset, 'sysadmin', 409)
self._action_post('package_create', dataset, 'sysadmin', 409)

dataset = {'name': 'should_not_be_created'}
res = self._action_post('package_create', dataset, 'no_org', 403)
self._action_post('package_create', dataset, 'no_org', 403)

def test_04_create_dataset_with_org(self):

dataset = {'name': 'admin_create_with_user', 'owner_org': 'org_with_user'}
res = self._action_post('package_create', dataset, 'sysadmin', 200)
self._action_post('package_create', dataset, 'sysadmin', 200)

dataset = {'name': 'sysadmin_create_no_user', 'owner_org': 'org_no_user'}
res = self._action_post('package_create', dataset, 'sysadmin', 200)
self._action_post('package_create', dataset, 'sysadmin', 200)

dataset = {'name': 'user_create_with_org', 'owner_org': 'org_with_user'}
res = self._action_post('package_create', dataset, 'no_org', 403)
self._action_post('package_create', dataset, 'no_org', 403)

def test_05_add_users_to_org(self):

Expand All @@ -120,19 +120,19 @@ def _add_datasets(self, user):

#org admin/editor should be able to add dataset to org.
dataset = {'name': user + '_dataset', 'owner_org': 'org_with_user'}
res = self._action_post('package_create', dataset, user, 200)
self._action_post('package_create', dataset, user, 200)

#not able to add dataset to org admin does not belong to.
dataset = {'name': user + '_dataset_bad', 'owner_org': 'org_no_user'}
res = self._action_post('package_create', dataset, user, 409)
self._action_post('package_create', dataset, user, 409)

#admin not able to make dataset not owned by a org
dataset = {'name': user + '_dataset_bad' }
res = self._action_post('package_create', dataset, user, 409)
self._action_post('package_create', dataset, user, 409)

#not able to add org to not existant org
dataset = {'name': user + '_dataset_bad', 'owner_org': 'org_not_exist' }
res = self._action_post('package_create', dataset, user, 409)
self._action_post('package_create', dataset, user, 409)

def test_07_add_datasets(self):
self._add_datasets('org_admin')
Expand All @@ -141,16 +141,16 @@ def test_07_add_datasets(self):
def _update_datasets(self, user):
##editor/admin should be able to update dataset
dataset = {'id': 'org_editor_dataset', 'title': 'test'}
res = self._action_post('package_update', dataset, user, 200)
self._action_post('package_update', dataset, user, 200)
# editor/admin tries to change owner org
dataset = {'id': 'org_editor_dataset', 'owner_org': 'org_no_user'}
res = self._action_post('package_update', dataset, user, 409)
self._action_post('package_update', dataset, user, 409)
# editor/admin tries to update dataset in different org
dataset = {'id': 'sysadmin_create_no_user', 'title': 'test'}
res = self._action_post('package_update', dataset, user, 403)
self._action_post('package_update', dataset, user, 403)
#non existant owner org
dataset = {'id': 'org_editor_dataset', 'owner_org': 'org_not_exist' }
res = self._action_post('package_update', dataset, user, 409)
self._action_post('package_update', dataset, user, 409)

def test_08_update_datasets(self):
self._update_datasets('org_admin')
Expand All @@ -159,10 +159,10 @@ def test_08_update_datasets(self):
def _delete_datasets(self, user):
#editor/admin should be able to update dataset
dataset = {'id': 'org_editor_dataset'}
res = self._action_post('package_delete', dataset, user, 200)
self._action_post('package_delete', dataset, user, 200)
#not able to delete dataset in org user does not belong to
dataset = {'id': 'sysadmin_create_no_user'}
res = self._action_post('package_delete', dataset, user, 403)
self._action_post('package_delete', dataset, user, 403)

def test_09_delete_datasets(self):
self._delete_datasets('org_admin')
Expand All @@ -171,21 +171,21 @@ def test_09_delete_datasets(self):
def test_10_edit_org(self):
org = {'id': 'org_no_user', 'title': 'test'}
#change an org user does not belong to
res = self._action_post('organization_update', org, 'org_editor', 403)
res = self._action_post('organization_update', org, 'org_admin', 403)
self._action_post('organization_update', org, 'org_editor', 403)
self._action_post('organization_update', org, 'org_admin', 403)

#change an org a user belongs to
org = {'id': 'org_with_user', 'title': 'test'}
res = self._action_post('organization_update', org, 'org_editor', 403)
res = self._action_post('organization_update', org, 'org_admin', 200)
self._action_post('organization_update', org, 'org_editor', 403)
self._action_post('organization_update', org, 'org_admin', 200)

def test_11_delete_org(self):
org = {'id': 'org_no_user', 'title': 'test'}
res = self._action_post('organization_delete', org, 'org_editor', 403)
res = self._action_post('organization_delete', org, 'org_admin', 403)
self._action_post('organization_delete', org, 'org_editor', 403)
self._action_post('organization_delete', org, 'org_admin', 403)
org = {'id': 'org_with_user'}
res = self._action_post('organization_delete', org, 'org_editor', 403)
res = self._action_post('organization_delete', org, 'org_admin', 403)
self._action_post('organization_delete', org, 'org_editor', 403)
self._action_post('organization_delete', org, 'org_admin', 403)


class TestAuthGroups(TestAuth):
Expand Down Expand Up @@ -255,11 +255,11 @@ def test_04_modify_group(self):
def test_05_delete_group(self):

org = {'id': 'group_with_user'}
res = self._action_post('group_delete', org, 'org_editor', 403)
res = self._action_post('group_delete', org, 'org_admin', 403)
self._action_post('group_delete', org, 'org_editor', 403)
self._action_post('group_delete', org, 'org_admin', 403)
org = {'id': 'group_with_user'}
res = self._action_post('group_delete', org, 'org_editor', 403)
res = self._action_post('group_delete', org, 'org_admin', 403)
self._action_post('group_delete', org, 'org_editor', 403)
self._action_post('group_delete', org, 'org_admin', 403)



Expand Down

0 comments on commit 120149b

Please sign in to comment.