[#306] Fix error where icon passed to qs in links

ckan · Jan 25, 2013 · 22ec8c1 · 22ec8c1
1 parent 75ef5fc
commit 22ec8c1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/ckan/lib/helpers.py b/ckan/lib/helpers.py
@@ -322,11 +322,11 @@ def _create_link_text(text, **kwargs):
         kwargs '''
         if kwargs.pop('inner_span', None):
             text = literal('<span>') + text + literal('</span>')
-        icon = kwargs.pop('icon', None)
         if icon:
             text = literal('<i class="icon-large icon-%s"></i> ' % icon) + text
         return text
 
+    icon = kwargs.pop('icon', None)
     class_ = _link_class(kwargs)
     return link_to(
         _create_link_text(text, **kwargs),