[#548] Fix broken password reset and add FIXMEs

ckan · Mar 5, 2013 · 2cdd1c5 · 2cdd1c5
1 parent 8d37013
commit 2cdd1c5
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/ckan/controllers/user.py b/ckan/controllers/user.py
@@ -416,6 +416,9 @@ def request_reset(self):
         return render('user/request_reset.html')
 
     def perform_reset(self, id):
+        # FIXME 403 error for invalid key is a non helpful page
+        # FIXME We should reset the reset key when it is used to prevent
+        # reuse of the url
         context = {'model': model, 'session': model.Session,
                    'user': c.user,
                    'keep_sensitive_data': True}
@@ -473,6 +476,7 @@ def _get_form_password(self):
                 raise ValueError(_('The passwords you entered'
                                  ' do not match.'))
             return password1
+        raise ValueError(_('You must provide a password'))
 
     def followers(self, id=None):
         context = {'for_view': True}