Skip to content

Commit

Permalink
Merge branch '2845-bug-editing-organization-removes-datasets' into re…
Browse files Browse the repository at this point in the history
…lease-v1.8
  • Loading branch information
amercader committed Aug 20, 2012
2 parents e7e4a02 + 6f7fa8b commit 49fca25
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
1 change: 1 addition & 0 deletions ckan/controllers/group.py
Expand Up @@ -340,6 +340,7 @@ def _save_edit(self, id, context):
tuplize_dict(parse_params(request.params))))
context['message'] = data_dict.get('log_message', '')
data_dict['id'] = id
context['allow_partial_update'] = True
group = get_action('group_update')(context, data_dict)

if id != group['name']:
Expand Down
13 changes: 10 additions & 3 deletions ckan/lib/dictization/model_save.py
Expand Up @@ -319,7 +319,14 @@ def group_member_save(context, group_dict, member_table_name):
model = context["model"]
session = context["session"]
group = context['group']
entity_list = group_dict.get(member_table_name, [])
entity_list = group_dict.get(member_table_name, None)

if entity_list is None:
if context.get('allow_partial_update', False):
return {'added': [], 'removed': []}
else:
entity_list = []

entities = {}
Member = model.Member

Expand Down Expand Up @@ -387,8 +394,8 @@ def group_dict_save(group_dict, context):
group_groups_changed = group_member_save(context, group_dict, 'groups')
group_tags_changed = group_member_save(context, group_dict, 'tags')
log.debug('Group save membership changes - Packages: %r Users: %r '
'Groups: %r Tags: %r', pkgs_edited, group_users_changed,
group_groups_changed, group_tags_changed)
'Groups: %r Tags: %r', pkgs_edited, group_users_changed,
group_groups_changed, group_tags_changed)

# We will get a list of packages that we have either added or
# removed from the group, and trigger a re-index.
Expand Down

0 comments on commit 49fca25

Please sign in to comment.