Fix an actual bug that prevented aliases from getting deleted when al…

…ias: [] has been provided
ckan · Sep 27, 2012 · 52e21aa · 52e21aa
1 parent 82cd9f0
commit 52e21aa
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/ckanext/datastore/db.py b/ckanext/datastore/db.py
@@ -303,18 +303,18 @@ def _get_aliases(context, data_dict):
 
 
 def create_alias(context, data_dict):
-    aliases = _get_list(data_dict.get('aliases', None))
-    if aliases:
+    aliases = _get_list(data_dict.get('aliases'))
+    if aliases != None:
         # delete previous aliases
         previous_aliases = _get_aliases(context, data_dict)
         for alias in previous_aliases:
             sql_alias_drop_string = u'DROP VIEW "{0}"'.format(alias)
             context['connection'].execute(sql_alias_drop_string)
 
         for alias in aliases:
-            sql_alias_string = u'CREATE VIEW"{alias}" AS SELECT * FROM "{main}"'.format(
-                main=data_dict['resource_id'],
-                alias=alias
+            sql_alias_string = u'CREATE VIEW "{alias}" AS SELECT * FROM "{main}"'.format(
+                alias=alias,
+                main=data_dict['resource_id']
             )
             context['connection'].execute(sql_alias_string)