Skip to content

Commit

Permalink
[#1117] Remove testing guidelines about assert messages
Browse files Browse the repository at this point in the history
This is unnecessary in most cases, should be clear from the test name
(or else the test may be doing too much)
  • Loading branch information
Sean Hammond committed Sep 23, 2013
1 parent 8bd5d35 commit 736a614
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions doc/testing-coding-standards.rst
Expand Up @@ -78,15 +78,6 @@ Clear

* Test methods and helper functions should have docstrings.

* Assert statements in tests should have assert messages to explain why the
test is doing this assert, e.g.::

assert result['success'] is False, ("Users shouldn't be able to update "
"other users' accounts")

Assert messages are printed out when tests fail, so the user can often see
what went wrong without even having to look into the test file.

Easy to find
It should be easy to know where to add new tests for some new or changed
code, or to find the existing tests for some code.
Expand Down

0 comments on commit 736a614

Please sign in to comment.