Skip to content

Commit

Permalink
Show vocab tags as normal tags by default
Browse files Browse the repository at this point in the history
Commit 7766386 changed the default behaviour of vocab tags so that
they are _not_ shown as normal tags (e.g. on the dataset read and search
pages). I thought this was a good idea because it's weird when you use
tag vocabulary to add a custom field, to see that tag also appear in the
normal tags. However, changing this behaviour breaks some tests, so I'm
changing it back!

If an extension is using a tag vocabulary to add a custom field, and it
doesn't want tags from that vocabulary to appear alongside normal tags,
then the extension can add the freet_tags_only converter to the schema
itself.
  • Loading branch information
Sean Hammond authored and tobes committed Feb 20, 2013
1 parent 3e072c6 commit 91086ac
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions ckan/logic/schema.py
Expand Up @@ -196,11 +196,7 @@ def db_to_form_package_schema():
schema = default_package_schema()

schema.update({
'tags': {
'__extras': [ckan.lib.navl.validators.keep_extras,
ckan.logic.converters.free_tags_only]
},
})
'tags': {'__extras': [ckan.lib.navl.validators.keep_extras]}})

# Add several keys to the 'resources' subschema so they don't get stripped
# from the resource dicts by validation.
Expand Down

0 comments on commit 91086ac

Please sign in to comment.