[#1583][s]: Tweaking hover-for-help mechanism.

ckan · Jan 24, 2012 · aded321 · aded321
1 parent 69f0bd1
commit aded321
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/ckan/lib/helpers.py b/ckan/lib/helpers.py
@@ -343,7 +343,7 @@ def resource_star_rating(resource_dict):
     out = ""
     if stars==0: 
         message = _('When we last checked, this resource was not available.');
-        out = literal('<a href="#" class="mouseover-help-link error-hint" data="%s">404?</a>' % message)
+        out = literal('<span class="hover-for-help error-hint" data="%s">404?</span>' % message)
     else:
         for n in range(stars):
             out += icon('star')

diff --git a/ckan/public/css/style.css b/ckan/public/css/style.css
@@ -207,14 +207,14 @@ tbody tr.table-empty td {
   font-size: 2.2em;
   font-weight: normal;
 }
-.mouseover-help-link {
-  border-bottom: 1px dashed #bb2222;
+.hover-for-help {
+  border-bottom: 1px dashed #000;
   position: relative;
 }
-.mouseover-help-link:hover {
-  border-bottom: 1px dashed #183661;
+.hover-for-help.no-underline {
+  border-bottom: none;
 }
-.mouseover-help-link .inner {
+.hover-for-help > .inner {
   position: absolute;
   top: 18px;
   left: -30px;
@@ -227,7 +227,7 @@ tbody tr.table-empty td {
   z-index: 3;
   color: #fff;
 }
-.mouseover-help-link:hover .inner {
+.hover-for-help:hover > .inner {
   display: block;
 }
 

diff --git a/ckan/public/scripts/application.js b/ckan/public/scripts/application.js
@@ -8,7 +8,7 @@
       CKAN.Utils.setupFormatAutocomplete($(this));
     });
     CKAN.Utils.setupMarkdownEditor($('.markdown-editor'));
-    CKAN.Utils.setupMouseoverHelpLinks($('.mouseover-help-link'));
+    CKAN.Utils.setupHoverForHelp($('.hover-for-help'));
 
     // set up ckan js
     var config = {
@@ -429,10 +429,9 @@ CKAN.Utils = function($, my) {
     });
   };
 
-  my.setupMouseoverHelpLinks = function(links) {
+  my.setupHoverForHelp = function(links) {
     $.each(links, function(n,link) {
       link = $(link);
-      link.click(function() { return false; });
       var div = $('<div />');
       div.html(link.attr('data'));
       div.addClass('inner');