Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[#2750] Add a convert_to_extras field to ExampleIDatasetFormPlugin
Add another custom field to ExampleIDatasetFormPlugin, one that uses convert_to/from_extras instead of convert_to/from_tags. I also had to make the plugin disable DefaultDatasetForm's check_data_dict() because it breaks with the new three-stage dataset creation when using convert_to_extras.
- Loading branch information
Sean Hammond
committed
Feb 27, 2013
1 parent
9de978e
commit aeb2687
Showing
2 changed files
with
20 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeb2687
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kindly Do you have a point of view on this? It seems that with the new three-stage dataset creation you can't use convert_to_extras because stages 1 and 2 submit only a partial dataset dict, which then gets passed to
check_data_dict()
which raises an error because keys are missing from the dict. In this commit I worked around it in the plugin. But we should fix it in core. Do we want to fix it or do we just want to removecheck_data_dict()
? I'm not really sure whatcheck_data_dict()
is for when we have the schemas.aeb2687
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't seem to have this problem when using convert_to_tags, I haven't looked into it to see exactly why yet