[#3009] Mark new activities terminology consistent

Always use new/old activities, don't mix in other terms like
read/unread, seen/unseen.

ckan/controllers/user.py

@@ -503,9 +503,9 @@ def dashboard(self, id=None):
 
         c.dashboard_activity_stream = h.dashboard_activity_stream(id)
 
-        # Mark the user's new activities as read whenever they view their
+        # Mark the user's new activities as old whenever they view their
         # dashboard page.
-        get_action('dashboard_mark_activities_as_read')(context, {})
+        get_action('dashboard_mark_all_new_activities_as_old')(context, {})
 
         return render('user/dashboard.html')
 

ckan/logic/action/get.py

@@ -2267,7 +2267,7 @@ def dashboard_new_activities_count(context, data_dict):
     return len([activity for activity in activities if activity['is_new']])
 
 
-def dashboard_mark_activities_as_read(context, data_dict):
+def dashboard_mark_all_new_activities_as_old(context, data_dict):
     '''Mark all the authorized user's new dashboard activities as old.
 
     This will reset dashboard_new_activities_count to 0.

ckan/tests/functional/api/test_dashboard.py

@@ -74,10 +74,10 @@ def dashboard_new_activities(self, user):
         activity_list = self.dashboard_activity_list(user)
         return [activity for activity in activity_list if activity['is_new']]
 
-    def dashboard_mark_activities_as_read(self, user):
+    def dashboard_mark_all_new_activities_as_old(self, user):
         params = json.dumps({})
         response = self.app.post(
-                '/api/action/dashboard_mark_activities_as_read',
+                '/api/action/dashboard_mark_all_new_activities_as_old',
                 params=params,
                 extra_environ={'Authorization': str(user['apikey'])})
         assert response.json['success'] is True
@@ -104,7 +104,7 @@ def test_02_own_activities_do_not_count_as_new(self):
         # We would have to do this if, when you follow something, you only get
         # the activities from that object since you started following it, and
         # not all its past activities as well.
-        self.dashboard_mark_activities_as_read(self.new_user)
+        self.dashboard_mark_all_new_activities_as_old(self.new_user)
 
         # Create a new dataset.
         params = json.dumps({
@@ -189,6 +189,6 @@ def test_06_mark_new_activities_as_read(self):
         her dashboard activity stream.'''
         assert self.dashboard_new_activities_count(self.new_user) > 0
         assert len(self.dashboard_new_activities(self.new_user)) > 0
-        self.dashboard_mark_activities_as_read(self.new_user)
+        self.dashboard_mark_all_new_activities_as_old(self.new_user)
         assert self.dashboard_new_activities_count(self.new_user) == 0
         assert len(self.dashboard_new_activities(self.new_user)) == 0