Skip to content

Commit

Permalink
remove useless route
Browse files Browse the repository at this point in the history
  • Loading branch information
@tobes
tobes committed Feb 28, 2012
1 parent c8a32ca commit b0b7822
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion ckan/config/routing.py
View file
Expand Up @@ -164,7 +164,6 @@ def make_map():
]))
)

m.connect('/dataset', action='index')
m.connect('/dataset/{action}/{id}/{revision}', action='read_ajax',
requirements=dict(action='|'.join([
'read',
Expand Down

8 comments on commit b0b7822

@rufuspollock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really useless? We want the dataset search to appear at /dataset and not /dataset/search :-)

@rufuspollock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really useless? We want the dataset search to appear at /dataset and not /dataset/search :-)

@rufuspollock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really useless? We want the dataset search to appear at /dataset and not /dataset/search ... :D

@rufuspollock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really useless? We want the dataset search to appear at /dataset and not /dataset/search ...

@tobes
Copy link
Contributor Author

@tobes tobes commented on b0b7822 Feb 29, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m.connect('/dataset', action='search') gets picked up first so the route is redundant. Plus package has no index method. Am I missing something?

@rufuspollock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is search should show up at /dataset now /dataset/search As long as that is still the case I'm absolutey delighted to see unnecessary routes go.

@tobes
Copy link
Contributor Author

@tobes tobes commented on b0b7822 Feb 29, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

search is at both /dataset and /dataset/search take you to the search - so I think we're good

@tobes
Copy link
Contributor Author

@tobes tobes commented on b0b7822 Feb 29, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for bad grammar

Please sign in to comment.