[#1210] Add auth_user_obj to context in check_access

If not already there or ignore_auth is True, and the context has a user
name, try to see if the user actually exists in the DB, and store the
object (or None if not found) in context['auth_user_obj']. The check if
performed only once per context object.

ckan/logic/__init__.py

@@ -208,6 +208,15 @@ def check_access(action, context, data_dict=None):
     user = context.get('user')
     log.debug('check access - user %r, action %s' % (user, action))
 
+    if not 'auth_user_obj' in context:
+        context['auth_user_obj'] = None
+
+    if not context.get('ignore_auth'):
+        if not context.get('__auth_user_obj_checked'):
+            context['__auth_user_obj_checked'] = True
+            if context.get('user') and not context.get('auth_user_obj'):
+                context['auth_user_obj'] = model.User.by_name(context['user'])
+
     if action:
         #if action != model.Action.READ and user in
         # (model.PSEUDO_USER__VISITOR, ''):

ckan/tests/logic/test_init.py

@@ -3,6 +3,8 @@
 import ckan.model as model
 import ckan.logic as logic
 
+from ckan.lib.create_test_data import CreateTestData
+
 
 class TestMemberLogic(object):
     def test_model_name_to_class(self):
@@ -11,3 +13,52 @@ def test_model_name_to_class(self):
                             logic.model_name_to_class,
                             model,
                             'inexistent_model_name')
+
+class TestCheckAccess(object):
+
+
+    @classmethod
+    def setup_class(cls):
+        model.Session.close_all()
+        model.repo.delete_all()
+
+    def setup(self):
+        model.repo.rebuild_db()
+
+    def test_check_access_auth_user_obj_is_set(self):
+
+        CreateTestData.create_test_user()
+
+        user_name = 'tester'
+        context = {'user': user_name}
+
+        result = logic.check_access('package_create', context)
+
+        assert result
+        assert context['__auth_user_obj_checked']
+        assert context['auth_user_obj'].name == user_name
+
+    def test_check_access_auth_user_obj_is_not_set_when_ignoring_auth(self):
+
+        CreateTestData.create_test_user()
+
+        user_name = 'tester'
+        context = {'user': user_name, 'ignore_auth': True}
+
+        result = logic.check_access('package_create', context)
+
+        assert result
+        assert '__auth_user_obj_checked' not in context
+        assert context['auth_user_obj'] is None
+
+    def test_check_access_auth_user_obj_is_not_set(self):
+
+        user_names = ('unknown_user', '', None,)
+        for user_name in user_names:
+            context = {'user': user_name}
+
+            result = logic.check_access('package_search', context)
+
+            assert result
+            assert context['__auth_user_obj_checked']
+            assert context['auth_user_obj'] is None