Skip to content

Commit

Permalink
Merge branch 'master' of ssh://github.com/okfn/ckan
Browse files Browse the repository at this point in the history
  • Loading branch information
David Read committed Jan 4, 2012
2 parents 79dcd5d + a1ca82b commit ce703d2
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 3 deletions.
3 changes: 3 additions & 0 deletions .gitattributes
@@ -0,0 +1,3 @@
*.po -diff
*.mo -diff
*.pot -diff
9 changes: 8 additions & 1 deletion ckan/controllers/group.py
Expand Up @@ -14,6 +14,7 @@
from ckan.logic import check_access, get_action
from ckan.logic.schema import group_form_schema
from ckan.logic import tuplize_dict, clean_dict, parse_params
from ckan.lib.dictization.model_dictize import package_dictize
import ckan.forms

class GroupController(BaseController):
Expand Down Expand Up @@ -95,15 +96,21 @@ def read(self, id):
c.group_description_formatted = desc_formatted
c.group_admins = self.authorizer.get_admins(c.group)

context['return_query'] = True
results = get_action('group_package_show')(context, data_dict)

c.page = Page(
collection=results,
page=request.params.get('page', 1),
url=h.pager_url,
items_per_page=50
items_per_page=30
)

result = []
for pkg_rev in c.page.items:
result.append(package_dictize(pkg_rev, context))
c.page.items = result

return render('group/read.html')

def new(self, data=None, errors=None, error_summary=None):
Expand Down
3 changes: 3 additions & 0 deletions ckan/logic/action/get.py
Expand Up @@ -439,6 +439,9 @@ def group_package_show(context, data_dict):
if limit:
query = query.limit(limit)

if context.get('return_query'):
return query

result = []
for pkg_rev in query.all():
result.append(package_dictize(pkg_rev, context))
Expand Down
4 changes: 2 additions & 2 deletions ckan/tests/functional/test_pagination.py
Expand Up @@ -54,11 +54,11 @@ def test_group_index(self):
def test_group_read(self):
res = self.app.get(url_for(controller='group', action='read', id='group_00'))
assert 'href="/group/group_00?page=2' in res
assert 'href="/dataset/package_49"' in res
assert 'href="/dataset/package_29"' in res

res = self.app.get(url_for(controller='group', action='read', id='group_00', page=2))
assert 'href="/group/group_00?page=1' in res
assert 'href="/dataset/package_50"' in res
assert 'href="/dataset/package_30"' in res

def test_users_index(self):
# allow for 2 extra users shown on user listing, 'logged_in' and 'visitor'
Expand Down

0 comments on commit ce703d2

Please sign in to comment.