Better checks: in debug mode only a critical exception if write permi…

…ssions on read-only db.
ckan · Sep 28, 2012 · eca6c28 · eca6c28
1 parent 0d97d5e
commit eca6c28
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/ckanext/datastore/plugin.py b/ckanext/datastore/plugin.py
@@ -51,7 +51,7 @@ def configure(self, config):
             # so that no harmful queries can be made
             if not ('debug' in config and config['debug']):
                 self._check_separate_db()
-                self._check_read_permissions()
+            self._check_read_permissions()
 
             self._create_alias_table()
         else:
@@ -155,7 +155,10 @@ def _check_read_permissions(self):
                         raise
                 else:
                     log.info("Connection url {0}".format(self.read_url))
-                    raise Exception("We have write permissions on the read-only database.")
+                    if 'debug' in self.config and self.config['debug']:
+                        log.critical("We have write permissions on the read-only database.")
+                    else:
+                        raise Exception("We have write permissions on the read-only database.")
                 finally:
                     read_trans.rollback()
         except Exception: