Package index not rebuilt when resources deleted #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I probably should not have done the pep8 fixes here but they were annoying me I can revert them if needed |
ghost
assigned 
| except ValidationError, e: | ||
| errors = e.error_dict['resources'][-1] | ||
| raise ValidationError(errors) | ||
|
|
||
| entity.delete() |
There was a problem hiding this comment.
Could you remove this line as this is purging the actual entity from the database, not just setting its state to 'deleted'.
kindly
added a commit
that referenced
this pull request
Jul 22, 2013
…kage Package index not rebuilt when resources deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like we should be updating the package here which will also force a reindex. Also looks like resource_group table is not being updated.
Should we fix bad data in these tables?