Confusing label on resource form #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Agreed to change text on that line to: File: Upload Link |
|
First button: "File" + tooltip, Second button: "Link" + tooltip, |
|
Notes for reviewer: This was decided within the dev call:
Please note: this pull request also tweaks the other occurrences of this plugin (group and org image attachment) to be in line with this change as well |
|
@amercader Can I assign to you for review+merge? |
|
@johnmartin Merged now, thanks for the quick work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File Upload may be misleading, because you might want to link to a file, web page or API on the web. For datastore-like files it makes sense, but for html, pdfs, zips etc. perhaps something more generic?
Also no field is marked as required.