Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0: Adding datasets to groups that you are not a part of #872

Closed
frank0051 opened this issue May 4, 2013 · 14 comments
Closed

2.0: Adding datasets to groups that you are not a part of #872

frank0051 opened this issue May 4, 2013 · 14 comments
Milestone

Comments

@frank0051
Copy link

Hi all, I think this might be a bug. Our install of 2.0 is from April 30 so this might have been fixed in one of the new contribs or there might be a config featuring were missing. In short:

The City of Houston and Code for Houston are trying to implement an open data portal for the region. The gameplan we’re discussing is for each government entity to be an organization with its own permissions while groups would be topical areas (like GIS, Environmental, Public Safety, etc.) and Departmental based catalogs of the datasets. Anyone in any of the organizations (or not in an organization who happens to have an account) could add their dataset to any one of the groups. In the CKAN demo site, any user can add a dataset to a group:
*See this dataset I added to the CKAN4RDM-test group: http://demo.ckan.org/dataset/test14

Over on our installation, however, I cannot add datasets to groups that weren't created by me (http://data.codeforhouston.com). We've tried adding logged_in as an editor and admin to some of the groups (feel free to try yourselves with group http://data.codeforhouston.com/group/members/city-of-houston-city-council), but that doesn't seem to be solving the problem. Is there some sort of commit that was added after April 30 or default setting in a config file that needs to be changed? If not, I think this might be a bug.

I know there is an outstanding issue to make it easier to find the permissions page for groups (#844) but that still doesn’t seem to solve the problem we're experiencing over on our side.

@frank0051
Copy link
Author

I can confirm the Code of Houston site is performing the same way as the http://beta.ckan.org/ - so it looks like we're probably using same branch. I think part of the issue is already outlined in this issue (#843) where groups that you aren't a member of show up in the add groups dropdown and are able to be selected. That said, what's the difference between the Demo CKAN site (the one that allows you to add datasets to groups you are not a part of) and the Beta site? Could it be a commit caused this issue or could there be a setting that needs to be changed?

@newsroomdev
Copy link

Making @frank0051 an admin of the CKAN instance and asking for an admin list. You may close this issue.

@frank0051
Copy link
Author

@geraldarthur, not quite sure that's the solution unless the http://demo.ckan.org automatically makes new users sysadmins. The question still remains: how is it that the demo site allows new users to add datasets to groups they aren't members of.

@newsroomdev
Copy link

@frank0051 cf the authorization documentation, what features are not currently in ckan2.0?

@frank0051
Copy link
Author

@geraldarthur The issue we've run up against is users that are not admins or are not editors/admins of a group cannot add their datasets to a group. CKAN’s demo site (linked provided in the first post) allows new user accounts to add datasets to whatever group they want, whereas the beta site and our site does not. It isn't related to the anonymous users and best I can tell it isn't outlined on the authorization document.

See also #844 - adding members to groups is not very easy. But in either case, it does look like something (may it be configuration or may it be a commit) is different between the Demo CKAN site and the Beta CKAN site.

@tobes
Copy link
Contributor

tobes commented May 7, 2013

HI,

I think there are a couple of issues here.

a) Adding members to groups is difficult to do as although the functionality exists is was not in the templates. /group/members/<group_name> This will be fixed but in the 2.1 release

b) The adding removing datasets to/from groups needs some polish. There are some issues around this some are fix others may be outstanding. Again this should be improved in 2.1

@frank0051
Copy link
Author

Hi @tobes , thanks for the response. While I definitely think those two issues are in the same wheelhouse (I even noticed the 1st open in the original post :-) ), I'm not sure either one is directly or indirectly responsible for what I'm getting at.

Please try this:

  1. Create an account on http://demo.ckan.org
  2. Add a new dataset. You'll notice your account is not part of an org, so you cannot add under an org.
  3. Now add your new dataset to a group (any group) and you can. Even groups you are not part of you can add datasets to. You cannot do this on the beta Ckan site or our fresh install at Code for Houston.

Two examples:

  1. Test dataset http://demo.ckan.org/dataset/test14 added to a group I'm not a member of : http://demo.ckan.org/group/members/ckan4rdm-test
  2. Test dataset http://demo.ckan.org/dataset/test34 added to a different group I'm not a member of: http://demo.ckan.org/group/members/example-group

So, there is either something different between the commits, an extra mod on the demo side, or a config property we're all just completely missing. Any ideas?

@tobes
Copy link
Contributor

tobes commented May 7, 2013

Please try this:

  1. Create an account on http://demo.ckan.org
  2. Add a new dataset. You'll notice your account is not part of an org, so you cannot add under an org.
  3. Now add your new dataset to a group (any group) and you can. Even groups you are not part of you can add > datasets to. You cannot do this on the beta Ckan site or our fresh install at Code for Houston.

This was a bug that has been fixed and should be in the 2.0 release - demo may not be running the latest 2.0 code. I can't find the issue as github search is now a real pain to use :(

@frank0051
Copy link
Author

So @tobes, are we saying that this functionality of removing open groups (the ability to add datasets to groups you are not a part of) was planned? I'm just trying to get a sense of the direction we're moving in. If so, are there plans to reintroduce logged_in so we could mimic this functionality?

@tobes
Copy link
Contributor

tobes commented May 7, 2013

are we saying that this functionality of removing open groups (the ability to add datasets to groups you are not a part of) was planned? I'm just trying to get a sense of the direction we're moving in. If so, are there plans to reintroduce logged_in so we could mimic this functionality?

good question @shevski any thoughts?

Allowing 'open groups' should be easy enough for us to add probably via a config setting. logged_in is part of the old auth stuff that has been replaced. In 2.0 we really focused on the Organizations. I think in 2.1 we should be able to add some polish to the groups. We are aware of some issues like the adding members.

@newsroomdev
Copy link

@tobes they're on 2.1 so I could just replace bits of the new config with the old config? hm...

where can i find copies of prior versions of config files?

@tobes
Copy link
Contributor

tobes commented May 8, 2013

new code would need writing to enable this.

where can i find copies of prior versions of config files?

not sure what you mean with this but everything is in git.

@newsroomdev
Copy link

derp. kk, thanks

@amercader
Copy link
Member

Closing as I think this has been fixed on recent CKAN versions, feel free to reopen if not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants