[WIP] [#1078] package_show performance improvements #1079
Conversation
|
@wardi We mark work in progress pull requests like this as [WIP] in the title. I've added this. Also we try to link our pull requests to the issue they are connected to. I use a crappy script I wrote https://github.com/tobes/gitlink other people use https://github.com/defunkt/hub or other solutions for this. This is not super important if you are just doing the odd issue/pull request, but it is really helpful as it reduces the number of issues and keeps the discussions in one place. Don't worry too much but it'd be good if you can do this. Also it might be harder with external repos but should be fine. |
|
fixes issue #1078 |
|
@tobes does that command let me associate a PR with the original issue, instead of creating a separate issue? That would be nice. I assume it's too late to do that for this one now. |
|
@wardi Yes, gitlink does it automatically for the current repo and branch you are in. However, your branch has to have the issue id in the name. If you use hub, the command is something like |
| package_dict, errors = _validate(package_dict, schema, context=context) | ||
|
|
||
| for item in plugins.PluginImplementations(plugins.IPackageController): | ||
| item.after_show(context, package_dict) |
There was a problem hiding this comment.
This looks a problem. If I add/remove a plugin from my .ini then it should change the results I see.
I'm not sure how we deal with this currently with the solr index.
unfortunately this part may need the json -> dict -> json cycle if IPackageControllers exist I'm not sure how we can get around this with the current interface.
There was a problem hiding this comment.
if our schemas were possible to serialize (using converter names instead of functions, say) then the validated data could store the hash of the schema that was used for generating it
Comments requested. These changes aren't perfect, lots of tests are failing, but I'm sure they can be fixed with a little help. I would like feedback on the changes below before proceeding.
Performance numbers so far, taking best of 10 runs for each: