Patches from hub.HealthData.gov

[JoshData]

Hi,

We're using CKAN behind hub.healthdata.gov (part of the new healthdata.gov).

We've had to make some patches to CKAN. Hoping to get these upstream so we don't have to worry about them when it's time to update.

FYI, the patch regarding accessibility was to address a legal requirement for U.S. federal government websites.

What do you think?

Best,

Josh

[tobes]

Thanks for these patches,

My initial thoughts

1. Accessibility patches - these seem a good idea (along with any other accessibility stuff) - we should check all templates are updated including (new style templates)

2. Escaping solr params - I know there was a patch related to escaping some things similar to this @icmurray was it you who did the patch(es) and did it fix this issue? Or was it unrelated?

3. Email - this is for the email link so I'm not sure if this is the best place in the new templates we are using h.mail_to for the logic instead of the link field which seems better to me - personally I'd remove these fields from the database entirely. Adding the message into the database also breaks translations @kindly have you any thoughts on this. I'd be happy for this patch to be used and the fields deprecated (possibly forcibly in package_dictize) for new templates

[tobes]

I have made a fresh pull request including your accessibility patch #129 hopefully it will be included in the upcoming 1.8 release

the other two issues are still being considered

[tobes]

@tauberer
Thanks for this. For us it is usually going to be easier to manage if you make a fresh branch/pull request for each feature you wish us to take as we can action them separately.

@kindly
This last commit (force utf8 not system encoding for postgres) feels like your domain

[JoshData]

I'll split them up in the future, thanks!

tobes notifications@github.com wrote:

@tauberer
Thanks for this. For us it is usually going to be easier to manage if
you make a fresh branch/pull request for each feature you wish us to
take as we can action them separately.

@kindly
This last commit (force utf8 not system encoding for postgres) feels
like your domain

---

Reply to this email directly or view it on GitHub:
#124 (comment)

JT

Sent from my tablet. Please excuse my brevity.

[tobes]

accessibility stuff has been added to 1.8 release

[JoshData]

Thanks!

[seanh]

The authors and maintainers names and emails fix has gone into CKAN 1.7.2, 1.8 and 2.0.

So I think there are still the legacy search params fix HHS@e383856 and the UTF8 encoding fix HHS@cbe6984 to merge

[amercader]

I've created separated pull requests for the pending patches (#160, #161)
Closing this one.