New DataStore UI fixes and tweaks #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
When logged in as a non-sysadmin user, you always got an error like: Process completed but unable to post to result_url This was caused by calling task_status_update, which is sysadmin only on datapusher_hook without ignore_auth in the context. We can safely add it at this point because access has been already checked. Added some tests.
|
Comments? From: To: |
|
@amercader Rename tab to just "DataStore" (from pull request call) and then assign to me for review |
|
@johnmartin silly pep8 test failing. I'll fix it after the call. |
johnmartin
added a commit
that referenced
this pull request
Dec 10, 2013
New DataStore UI fixes and tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.