[WIP] for comment: Ckan test helper

ckan/logic/action/create.py

@@ -773,7 +773,7 @@ def user_create(context, data_dict):
 
     activity_create_context = {
         'model': model,
-        'user': context['user'],
+        'user': context.get('user'),
         'defer_commit': True,
         'session': session
     }

ckan/logic/auth/create.py

@@ -5,8 +5,8 @@
 
 
 def package_create(context, data_dict=None):
-    user = context['user']
-    if not new_authz.auth_is_registered_user():
+    user = context.get('user')
+    if not user:
         check1 = new_authz.check_config_permission('anon_create_dataset')
     else:
         check1 = new_authz.check_config_permission('create_dataset_if_not_in_organization') \
@@ -23,8 +23,8 @@ def package_create(context, data_dict=None):
     return {'success': True}
 
 def file_upload(context, data_dict=None):
-    user = context['user']
-    if not new_authz.auth_is_registered_user():
+    user = context.get('user')
+    if not user:
         return {'success': False, 'msg': _('User %s not authorized to create packages') % user}
     return {'success': True}
 
@@ -96,10 +96,10 @@ def rating_create(context, data_dict):
     return {'success': True}
 
 def user_create(context, data_dict=None):
-    user = context['user']
 
     if ('api_version' in context
             and not new_authz.check_config_permission('create_user_via_api')):
+        user = context['user']
         return {'success': False, 'msg': _('User %s not authorized to create users') % user}
     else:
         return {'success': True}

ckan/logic/auth/update.py

@@ -23,7 +23,7 @@ def package_update(context, data_dict):
         )
     else:
         # If dataset is not owned then we can edit if config permissions allow
-        if new_authz.auth_is_registered_user():
+        if user:
             check1 = new_authz.check_config_permission(
                 'create_dataset_if_not_in_organization')
         else:

ckan/new_authz.py

@@ -292,13 +292,3 @@ def check_config_permission(permission):
     if permission in CONFIG_PERMISSIONS:
         return CONFIG_PERMISSIONS[permission]
     return False
-
-
-
-def auth_is_registered_user():
-    ''' Do we have a logged in user '''
-    try:
-        context_user = c.user
-    except TypeError:
-        context_user = None
-    return bool(context_user)