Recurring WebApp Error: <type 'exceptions.KeyError'>: u'mins'

[amercader]

I'm getting loads of these, apparently mostly caused by googlebot. A quick inspection doesn't show any mins key in the code, so not sure what is going on.

Full traceback: https://gist.github.com/amercader/5575150

File '/usr/lib/ckan/beta/src/ckan/ckan/templates/page.html', line 65 in block "main_content"
  {% block primary %}
File '/usr/lib/ckan/beta/src/ckan/ckan/templates/page.html', line 78 in block "primary"
  {% block primary_content %}{% endblock %}
File '/usr/lib/ckan/beta/src/ckan/ckan/templates/package/resource_read.html', line 70 in block "primary_content"
  {% block resource_additional_information %}
File '/usr/lib/ckan/beta/src/ckan/ckan/templates/package/resource_read.html', line 99 in block "resource_additional_information"
  {% for key, value in h.format_resource_items(res.items()) %}
File '/usr/lib/ckan/beta/src/ckan/ckan/lib/helpers.py', line 1459 in format_resource_items
  value = formatters.localised_nice_date(datetime_)
File '/usr/lib/ckan/beta/src/ckan/ckan/lib/formatters.py', line 91 in localised_nice_date
  days).format(days=days)
KeyError: u'mins'

[tobes]

@amercader this is a translation error with the cs_CZ

one: {days} day ago
other: {days} days ago

one: před {mins} dnem
few: před {mins} dny
other: před {mins} dny

This probably should

a) be fixed in a point release
b) We should write tests to check translations are correct. I'd be happy to do this as part of my coding standards tests or as part of the translation paster jobs.

[amercader]

Thanks for looking into this. +1 to both.

[tobes]

I've created #903 for translation checking/tests - so this issue is only for this specific issue now

[amercader]

@tobes can you have a quick look at this one? I've also updated the translations on Transifex

[tobes]

@amercader this looks good to me. Can you do the merge into the 2.0.1 release :)

If I have time I'll look at creating a translation tester next week to check them all for such errors

[amercader]

@tobes, ok do you want to merge this into master or should I close it?

[tobes]

@amercader I'm not sure what the state of translations in master is. If we have the current 2.0 ones then we should update these I suppose. @seanh is this the sort of thing we want to merge into master or do we just wait till we do the next translation pull? I suppose if some one installs from source this might be an issue but their translations will be incomplete anyhow.

[amercader]

@seanh updated the translations on master from 2.0 some days ago (82f45de), so I think is worth merging, as the translations on master are up to date

[tobes]

merged