New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Analytics Event Tracking for CKAN API #6
Conversation
of the CKAN API can be reported on via Google Analytics.
@seanh @rossjones @dread who might review this? |
@@ -2,6 +2,19 @@ | |||
from ckan.lib.base import BaseController, c, render | |||
import dbutil | |||
|
|||
import urllib | |||
from pprint import pprint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused?
I guess a run through PEP8 wouldn't hurt either (I don't care but travis does, or at least it did). At least for me, I'd create the threads up-front and feed them via an internal queue, but perhaps it would be worth measuring thread-creation under load. Am sure this'll work in most use-cases though. |
@maxious is anything holding you up from responding to @rossjones review? I imagine ti would be nice to get this merged if it was satisfactory ... @davidread any thoughts at your end? |
These are useful changes - if @maxious could tidy up the odd thing suggested by the comments we can merge it. |
Heya folks, We'll have this scheduled as part of @maxious 's day job :) Should get things sorted soon. We might get Sergey to do the work, but either way we'll take this on very soon and get it done :) Feel free to ping me for any other pull requests so that I can schedule work under our CKAN Association gold membership agreement. @maxious kinda has two hats but where its work that Link Digital can take on then you can certainly feel free to put the pressure on me :) |
@rgrp @davidread Okay, actioned feedback + PEP8 compliance. |
@davidread @rossjones is one of you able to review this? (I'm almost certainly not the right person :-) ...) |
I like it. @rossjones ? |
Might be useful to allow people to turn it off if they wish? I didn't miss it did I? Other than that, looks okay. |
@rossjones I guess it's easy enough for someone to add config for turning it off, should this be necessary. Merging. |
Google Analytics Event Tracking for CKAN API
hah! I love it when I get credit for doing nothing ;) This is all work from Maxious. I'm pretty sure he hasn't used and 'day job' Anyhoo - its handy to have stats connected to the CKAN platform requests so Cheers, _STEVEN DE COSTA *| On 5 November 2014 22:38, David Read notifications@github.com wrote:
|
Intercept some CKAN API routes (not autocomplete, i18n etc.) and send a page view and event to Google Analytics via the new Measurement Protocol API https://developers.google.com/analytics/devguides/collection/protocol/v1/