New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ISiteSearch interface #2
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
==========================================
+ Coverage 91.13% 91.29% +0.16%
==========================================
Files 16 18 +2
Lines 1150 1286 +136
==========================================
+ Hits 1048 1174 +126
- Misses 102 112 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @pdelboca ! Only two minor comments. Also please add a small mention in the README about the interface (you can link to interfaces.py
for the documentation) and run black
on all files before pushing, thanks!
Co-authored-by: Adrià Mercader <amercadero@gmail.com>
…ca/ckanext-sitesearch into add-isitesearch-interface
Done @amercader ! I do not have permissions to merge. |
@pdelboca thanks, you should have perms now |
This PR adds a new
ISiteSearch
to allow users to hook specific logic before/after each type of search.This is inspired by
before_package_search
andafter_package_search
methods implemented in IPackageController: