add _id to resultobj #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markmacgillivray can this merge? Also, assume as owner you are still watching this repo :-) |
|
This one is really possible purely from the ES side. Adding that extra loop in just to add the _id will lead to some additional slowness (particularly if the result set is large) in all cases whilst only being useful in some. So not sure it should be merged (not that facetview has ever been coded for performance...). Still watching the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across the problem that I need the documentId _id in the resultobj to do some Javascript hide()/show() stuff. This PR contains my solution to add it always (first steps with facetview & second steps with Elasticsearch, so feel free to reject it :-)