Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pictures: #33

Open
onalya opened this issue Nov 21, 2022 · 7 comments
Open

Pictures: #33

onalya opened this issue Nov 21, 2022 · 7 comments
Assignees

Comments

@onalya
Copy link
Collaborator

onalya commented Nov 21, 2022

Pictures in the Global directory were supposed to be actual pictures, not drawings (or at least not a white backgroud, except for the placeholder drawing), I find it a little chaotic to have different styles. What do you think? @sapetti9

@sapetti9 sapetti9 self-assigned this Nov 21, 2022
@sapetti9
Copy link
Collaborator

Yes, we did discuss this with @lucpretti too. I agree. I'll collect the pics and change them.

@onalya
Copy link
Collaborator Author

onalya commented Nov 21, 2022

Also, they shuld be cutted accordingly, do you think that's possible? Like 300x160. @aivuk then was talking about thumbnails, but probably autogenerated...

@sapetti9
Copy link
Collaborator

I can try to edit all images to have them in 300x160 (px?), but won't be able to do it before Thursday. Do you think that will solve also the issue with the layout, which is currently cutting people's eyes?

@onalya
Copy link
Collaborator Author

onalya commented Nov 22, 2022

We should edit at least the ones where people's eyes are cutted yes, I can probably do it before Thursday. Better if I do a check once, like after we have the final set of pics.

@aivuk
Copy link
Collaborator

aivuk commented Nov 22, 2022

@onalya and @sapetti9 I did a different approach to adjust the specialist pictures because how the picture are positioned in css (using background-position: 50%), just resizing the pictures would not solve the issue. Now we have on the okfn-network-experts.csv a new column called "Photo-position". You can put a number between 0 and 100 and I'm using it to position the photo. If you want to use the default position, just leave it blank. I already adjusted all the photos that had the eyes cut.

@onalya
Copy link
Collaborator Author

onalya commented Nov 22, 2022

Ok, probably less accessible as a solution since it requires some specific knowledge. The picture is not provided in the form, I guess who is going to look for it can choose one where the subject is in a suitable position, or simply cut it by eye.

@aivuk
Copy link
Collaborator

aivuk commented Nov 23, 2022

yes @onalya, this solution will work because we will do a triage and select (or ask the specialist) the photos ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants