Skip to content
This repository has been archived by the owner on Aug 3, 2022. It is now read-only.

Added flat CSV downloading option for Census #1156

Merged
merged 5 commits into from Jul 4, 2018
Merged

Added flat CSV downloading option for Census #1156

merged 5 commits into from Jul 4, 2018

Conversation

@roll roll changed the title [WIP] Improved results downloading [WIP] Added flat CSV downloading option for Census Jul 3, 2018
@roll
Copy link
Contributor Author

roll commented Jul 3, 2018

@dannylammerhirt
Please take a look (downloadable example in the first comment)

If the format in-general looks good I would suggest going thru column naming https://github.com/okfn/opendatasurvey/pull/1156/files#diff-72eef72e4a22ddeab37bd383e417cc58R314 to make it a little bit more consistent/human-friendly (I used the Google Doc but it's clearly a draft)

@roll roll changed the title [WIP] Added flat CSV downloading option for Census Added flat CSV downloading option for Census Jul 3, 2018
@roll roll requested a review from brew July 3, 2018 12:09
@roll
Copy link
Contributor Author

roll commented Jul 3, 2018

@brew
Could you please review?

Also I think I need a hand to deploy these changes to http://test-african-data.survey.okfn.org/

Copy link
Collaborator

@brew brew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

When you merge with master, and Travis has successfully run, a tagged release should be built on docker hub automatically (https://hub.docker.com/r/openknowledge/opendatasurvey/tags/). Use that tag as the release tag in our devops repo and do a make deploy... for the opendatasurvey as normal. This will update for all the surveys, not just test-africa-data.

@roll roll merged commit fb3ebb3 into master Jul 4, 2018
@roll roll deleted the dowload-results branch July 4, 2018 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants