232 - Internet Explorer 7 & 8 fixes #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because Internet Explorer <= 8 has `delete` as a reserved keyword that you cannot name your methods
…browsers that don\'t support them
|
@johnmartin thanks for these fixes - very useful. We have been aiming to run jshint regularly and that should catch e.g. trailing commas. |
rufuspollock
added a commit
that referenced
this pull request
Oct 2, 2012
[ie fixes][s]: Internet Explorer 7 & 8 fixes - fixes #232.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few JavaScript and minor visual fixes for Recline in Internet Explorer 7 & 8.
Couple of quick dev notes:
,use. You can't end a line with a,if it doesn't need one. E.g.var test = [ test: 'test', ];will NOT validate[1, 2, 3].filter()) and therefore I had to add them indeletefor method names. It's a reserved keyword and it throws a little tantrum if you do. It's good practice not to use it anyways as it is a reserved keyword according to the ECMAScript guidelines. See 1 and 2 for more info