Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links open in new window #40

Closed
agm3dc opened this issue Apr 11, 2013 · 5 comments
Closed

Links open in new window #40

agm3dc opened this issue Apr 11, 2013 · 5 comments
Assignees

Comments

@agm3dc
Copy link

agm3dc commented Apr 11, 2013

Since opening a link means losing your place in the timeline, it would be fantastic if links opened in new windows. Thanks again for the awesome tool.

@djw
Copy link
Contributor

djw commented Apr 12, 2013

Are there any links on the view page that we don't want to open in new windows? If not, it's trivial to add

<base target="_blank" />

to the page head.

@agm3dc
Copy link
Author

agm3dc commented Apr 12, 2013

I think it ALWAYS makes sense to open in new window. I'm virtually code illiterate so not sure that answers your question.... thx for your help.

@rufuspollock
Copy link
Member

@djw I think all links within the part of the page that would be embedded (i.e. timeline, map, footer) should open in a remote window but those in the navbar i'm not sure about ...

I think we could just try and see if that causes any problems ...

@agm3dc
Copy link
Author

agm3dc commented Apr 12, 2013

We've been putting links in the descriptions, which is what I was referring to. Here's an example:
September 2, 2011

NDI and World Bank Institute launch global PMO report

NDI and WBI launch "Strengthening Parliamentary Accountability, Citizen Engagement and Access to Information: A Global Survey of Parliamentary Monitoring Organizations." The report identifies nearly 200 parliamentary monitoring organizations (PMOs) around the world. http://bit.ly/17oVyyu

http://www.openingparliament.org/about

@djw
Copy link
Contributor

djw commented Apr 15, 2013

@rgrp On the view page, I can't see any links which aren't present in the embed. If there are any links we want to open in the same window we can explicitly state target=_self.

@ghost ghost assigned djw Apr 15, 2013
@djw djw closed this as completed in 1e026d0 Apr 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants