fix(index): consider paths relative to git root - #118, #120

[rodneyrehm]

this PR is following up on the question in #120 regarding its possible fix for issue #118. It does not contain the suggested removal of the matchBase option, but makes clear that this option effectively makes *.js works like **/.js, which is not necessarily expected behavior.

• changing lint-staged to run minimatch patterns against paths relative to the directory .git is in, while passing absolute paths to the linters
• removing obsolete src/resolveFiles.js and test
• adding note to README about how directories and patterns work
• improving generateTasks tests to be simpler to read

[okonet]

LGTM!

[okonet]

@rodneyrehm is the #118 closed by this? Can you point me to the exact test case?

[rodneyrehm]

Yes, #118 is closed by this. There is no specific test case as generateTasks() now simply matches agains a relative path and returning the corresponding absolute path. That the relative paths are in fact relative to the git directory is not covered by any test. The static files map you see in test/generateTasks.spec.js It's generated by the following part in src/index.js:

const resolvedFiles = {}
files.forEach((file) => {
  const absolute = path.resolve(gitDir, file.filename)
  const relative = path.relative(gitDir, absolute)
  resolvedFiles[relative] = absolute
})