Bug fix for issue #114

[sudo-suhas]

On Windows, if the same execaOptions are re-used for running 'linters' in runScripts.js windowsVerbatimArguments: true options will be added which breaks the git add command if present with following error:

{ Error: spawn undefined ENOENT
    at notFoundError (E:\workspace\odyssey\node_modules\cross-spawn\lib\enoent.js:11:11)
    at verifyENOENT (E:\workspace\odyssey\node_modules\cross-spawn\lib\enoent.js:46:16)
    at ChildProcess.cp.emit (E:\workspace\odyssey\node_modules\cross-spawn\lib\enoent.js:33:19)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
  errno: 'ENOENT',
  code: 'ENOENT',
  syscall: 'spawn undefined',
  killed: false,
  stdout: '',
  stderr: 'git: \'Files\\Git\\cmd\\git.EXE\' is not a git command. See \'git --help\'.\n',
  failed: true,
  signal: null,
  cmd: 'C:\\Program Files\\Git\\cmd\\git.EXE add -- E:\\workspace\\odyssey\\build\\webpack.base.conf.js',
  timedOut: false }

Error is reproducible using this simple script:

'use strict';

const execa = require('execa');

const res = {
    bin: 'C:\\Program Files\\Git\\cmd\\git.EXE',
    args: [
        'add',
        '--',
        'E:\\workspace\\odyssey\\build\\webpack.base.conf.js'
    ]
};

execa(res.bin, res.args, {
        cwd: 'E:\\workspace\\odyssey',
        windowsVerbatimArguments: true
    })
    .then(() => {
        console.log('worked!');
    })
    .catch(err => {
        console.log(err);
    });

[okonet]

Hey @sudo-suhas! Thanks for the effort and this PR. I'm still not sure how is re-using of execaOptions object can lead to windowsVerbatimArguments: true in it. Is this something OS-related?

[sudo-suhas]

@okonet I don't know enough about execa to answer that. Sorry. Since it says Windows in the option name, it must be due to windows OS. If there is some test you want me to run, I can.

[okonet]

In the example you mentioned you've added windowsVerbatimArguments: true to the options manually. We don't do that in lint-staged. I'm wondering how is the fix works.

[sudo-suhas]

I simply logged the execaOptions before each call. I saw that the windowsVerbatimArguments: true parameter was being added to the options. The obvious conclusion is that execa introduces it for internal use. But when we pass the same options to the git call, it breaks. Which was why I showed the test code with that argument.

[okonet]

Awesome! Thanks for the fix! It will be released automatically soon.