Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require at least Node.js 18.12.0 #1322

Merged
merged 2 commits into from Sep 12, 2023
Merged

feat: require at least Node.js 18.12.0 #1322

merged 2 commits into from Sep 12, 2023

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented Sep 9, 2023

Require at least Node.js 18.12.0

This release drops support for Node.js 16, which is EOL after 2023-09-11.
Please upgrade your Node.js to the latest version.

Additionally, all dependencies have been updated to their latest versions.

@iiroj iiroj requested a review from okonet September 9, 2023 19:22
@iiroj
Copy link
Member Author

iiroj commented Sep 9, 2023

Ping @okonet , merging this PR should open an automatic 🦋 changeset PR, which will create a new release when merged.

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@okonet
Copy link
Collaborator

okonet commented Sep 10, 2023

I removed the node 16 from required checks.

@iiroj iiroj merged commit f85be25 into master Sep 12, 2023
16 checks passed
@iiroj iiroj deleted the node-16-eol branch September 12, 2023 03:39
@iiroj
Copy link
Member Author

iiroj commented Sep 12, 2023

@okonet Something went wrong with creating the chageset PR: https://github.com/okonet/lint-staged/actions/runs/6154606596/job/16700278548#step:6:56

I guess the GITHUB_TOKEN needs some permission changes.

@iiroj
Copy link
Member Author

iiroj commented Sep 12, 2023

Hmm, that is the built-in token which works fine in my own project... let me search around what causes this.

@iiroj
Copy link
Member Author

iiroj commented Sep 12, 2023

This might be because of the permission boundary in the workflow, let me open a PR:

https://github.com/okonet/lint-staged/blob/f85be258c1fafe46feb550d0c511cb40c89216d8/.github/workflows/push.yml#L12-L13

EDIT: needs pull-requests as well: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

@github-actions github-actions bot mentioned this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants