Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦋 Changeset release #1328

Merged
merged 1 commit into from Oct 14, 2023
Merged

🦋 Changeset release #1328

merged 1 commit into from Oct 14, 2023

Conversation

github-actions[bot]
Copy link
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

lint-staged@15.0.0

Major Changes

  • #1322 66b93aa Thanks @iiroj! - Require at least Node.js 18.12.0

    This release drops support for Node.js 16, which is EOL after 2023-09-11.
    Please upgrade your Node.js to the latest version.

    Additionally, all dependencies have been updated to their latest versions.

@iiroj
Copy link
Member

iiroj commented Sep 16, 2023

Woohoo, finally got this far @okonet !

@iiroj
Copy link
Member

iiroj commented Sep 16, 2023

I wonder why this PR is not triggering the usual actions.

@iiroj
Copy link
Member

iiroj commented Sep 16, 2023

@okonet what do you think, should we just remove the "required/expected checks"? IMO as long a PR cannot be merged without an approval, and all checks are passing, it should be fine...

@iiroj
Copy link
Member

iiroj commented Sep 16, 2023

This indicates that when using the GITHUB_TOKEN, it won't trigger a new workflow: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow

@okonet
Copy link
Collaborator

okonet commented Sep 16, 2023

I’d rather keep the checks and use administrative rights to merge for these kind of PRs

okonet
okonet previously approved these changes Sep 16, 2023
@okonet
Copy link
Collaborator

okonet commented Sep 16, 2023

Feel free to merge if you’re happy with it.

@iiroj
Copy link
Member

iiroj commented Sep 16, 2023

Alternatively we could set up a PAT instead of using the default GITHUB_TOKEN. I will also google around if there's other ways.

@iiroj
Copy link
Member

iiroj commented Sep 17, 2023

I guess just using the admin powers to merge is fine. I'll create a new small PR just to make sure this changeset PR gets automatically updated correctly.

@iiroj
Copy link
Member

iiroj commented Oct 14, 2023

@okonet feel free to merge this, I don't have permissions because of the required checks.

@okonet
Copy link
Collaborator

okonet commented Oct 14, 2023

You should be able now. Let me know…

@iiroj iiroj merged commit 59ff2ef into master Oct 14, 2023
@iiroj iiroj deleted the changeset-release/master branch October 14, 2023 17:29
@iiroj
Copy link
Member

iiroj commented Oct 14, 2023

Unfortunately, we need to set up a Personal Access Token for running the Actions, since now the tag workflow didn't trigger. Can you publish 15.0.0 manually to npm? I'll open a PR for the PAT change.

@iiroj
Copy link
Member

iiroj commented Oct 14, 2023

On second thought, I will try to re-create the v15.0.0 git tag to trigger the Action.

@iiroj
Copy link
Member

iiroj commented Oct 14, 2023

I was able to make it work by adjusting the CI config a bit, and creating the Personal Access Token. Unfortunately, I have a npm script collision with the name publish... have to change that.

EDIT: PR here #1336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants