Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File matching incorrect #173

Closed
georeith opened this issue May 17, 2017 · 2 comments
Closed

File matching incorrect #173

georeith opened this issue May 17, 2017 · 2 comments

Comments

@georeith
Copy link
Contributor

georeith commented May 17, 2017

The following pattern:

{,!(node_modules|lib)/**/}{.*,*}.js

Is matching this file:

lib/my-file.lib.js

This should not be the case, See here.

@okonet
Copy link
Collaborator

okonet commented May 19, 2017

Here is how we match files: https://github.com/okonet/lint-staged/blob/master/src/generateTasks.js#L11

Can you see the problem here?

@georeith
Copy link
Contributor Author

georeith commented Jun 1, 2017

@okonet it's to do with matchBase option it seems which makes a lot of negation patterns very hard to write (I haven't yet found a way to convert this).

What are your thoughts about taking glob options in the advanced config format to override the default minimatch settings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants