Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not swallow already detected deprecated usage by last task #991

Merged
merged 1 commit into from Jul 13, 2021

Conversation

@bobisjan
Copy link
Contributor

@bobisjan bobisjan commented Jul 12, 2021

No description provided.

@bobisjan bobisjan force-pushed the git-add-detection-fix branch 3 times, most recently from 042d637 to aba6501 Jul 13, 2021
@bobisjan bobisjan force-pushed the git-add-detection-fix branch from bf170f4 to 4aed52c Jul 13, 2021
@codecov
Copy link

@codecov codecov bot commented Jul 13, 2021

Codecov Report

Merging #991 (4aed52c) into master (4f9a146) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #991   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          611       612    +1     
  Branches       144       145    +1     
=========================================
+ Hits           611       612    +1     
Impacted Files Coverage Δ
lib/runAll.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f9a146...4aed52c. Read the comment docs.

Loading

@iiroj
Copy link
Collaborator

@iiroj iiroj commented Jul 13, 2021

Thanks, this looks like a clear bug. Does this mean the warning is not shown if a task using git add is followed by another that doesn't?

Loading

@bobisjan
Copy link
Contributor Author

@bobisjan bobisjan commented Jul 13, 2021

Does this mean the warning is not shown if a task using git add is followed by another that doesn't?

Yes, that was exactly our case.

TBH I've failed to update the test with following config, it looks that snapshots are not stable across platforms? (AppVeyor passed, but Ubuntu failed with different order of the output)

{
  '*.js': ['prettier --write', 'git add'],
  '**/*.js': ['prettier --write']
}

Loading

@iiroj
Copy link
Collaborator

@iiroj iiroj commented Jul 13, 2021

We really should get rid of Appveyor and start using GitHub Actions for Windows as well, but yeah, that requires a lot of rework with the testing setup...

In any case, I'll merge this since it seems straightforward enough.

Loading

@iiroj iiroj self-requested a review Jul 13, 2021
iiroj
iiroj approved these changes Jul 13, 2021
@iiroj iiroj merged commit 7734156 into okonet:master Jul 13, 2021
11 checks passed
Loading
@bobisjan bobisjan deleted the git-add-detection-fix branch Jul 13, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Jul 13, 2021

🎉 This PR is included in version 11.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants