Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added maxSize and minSize validation #104 #202

Merged
merged 1 commit into from Aug 19, 2016
Merged

added maxSize and minSize validation #104 #202

merged 1 commit into from Aug 19, 2016

Conversation

lemuelbarango
Copy link
Contributor

fix for file validation #104

@okonet
Copy link
Collaborator

okonet commented Jul 26, 2016

That's awesome! Thanks for contributing. To be honest, I think this should not be a part of the library but should live in a userland and this lib should allow it by providing a callback. Some users might want size validation but the other part might want to do something more complex or different. This doesn't scale ATM.

My idea was to have a callback function that users can pass along with other props and it should get called in onDrop function. I might get some time to work on it soon-ish, but if you feel like it, please go for it!

Does it make sense?

@prabhu
Copy link

prabhu commented Aug 17, 2016

Great PR. I disagree. This should be part of the library. Callback for customising max and min size is frankly an overkill.

@okonet okonet merged commit c6f072a into react-dropzone:master Aug 19, 2016
@okonet okonet mentioned this pull request Aug 19, 2016
@okonet
Copy link
Collaborator

okonet commented Aug 29, 2016

@lemuelbarango can you please also update the README?

@lemuelbarango
Copy link
Contributor Author

Yeah I can

On Aug 29, 2016 3:57 AM, "Andrey Okonetchnikov" notifications@github.com
wrote:

@lemuelbarango https://github.com/lemuelbarango can you please also
update the README?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#202 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHDW6zHm0k6Mdz7wyqfi2cDQPjOsuBfBks5qkpDTgaJpZM4JUPVx
.

@albertkawmi
Copy link

albertkawmi commented Sep 1, 2016

@lemuelbarango @okonet thanks for this. Will this update be published on npm?

edit: apologies, just realised last change was only 3 days ago...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants