Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinates outside 0-19 range #26

Closed
onyxiguana opened this issue Feb 27, 2022 · 2 comments
Closed

coordinates outside 0-19 range #26

onyxiguana opened this issue Feb 27, 2022 · 2 comments

Comments

@onyxiguana
Copy link

onyxiguana commented Feb 27, 2022

Three of the x coordinates in hard.js and one in easy.js has been set to "x":104, which is outside the range 1-19. It seems this causes the problems to be unsolvable. All other coordinates are within the 1-19 range.

Puzzle-specific details (in case of spoilers) This issue affects the hard josekle puzzle today (#27). Checking against the OGS dictionary, they are all on the H line, so should be 8 instead?
@yewang
Copy link
Collaborator

yewang commented Feb 27, 2022

Thanks for the report. Confirming that there is an issue.

I have manually fixed today's hard puzzle, but the others still need to be checked and fixed, and we need to get to the root cause that led to the incorrect data.

@okonomichiyaki
Copy link
Owner

thanks for the bug report @onyxiguana
this should be fixed now in all the puzzles hard and easy, and the root cause in the OJE scraper is fixed too (translation of coordinate systems)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants