Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prestashop 8 #125

Closed
Kandax86 opened this issue Aug 30, 2022 · 4 comments
Closed

Prestashop 8 #125

Kandax86 opened this issue Aug 30, 2022 · 4 comments

Comments

@Kandax86
Copy link

Hi, i tried to install your theme and modules to prestashop 8 beta but it seems its not compatible, some abstract functions had been added and so the module can't be installed.
Do you plan to make it compliant with prestashop 8?

Thank you in advance

Cedric

@Kandax86
Copy link
Author

  • i notice an error in SmartyHelperFunctions file line 45.
    u wrote
    return implode($attributesToPrint, PHP_EOL);
    instead of
    return implode(PHP_EOL, $attributesToPrint);

Cédric

@Oksydan Oksydan transferred this issue from Oksydan/is_themecore Sep 22, 2022
@Oksydan
Copy link
Owner

Oksydan commented Sep 22, 2022

Hi @Kandax86,

for some reason I didn't get notification about this issue in is_themecore module.
This issue has been transferred to starter project.

Yes, version 3.0 is WIP atm and will it be available probably with 8.0 prestashop release.
Thank you for your issue ❤️

@Oksydan Oksydan added bug Something isn't working native module labels Sep 22, 2022
@Oksydan
Copy link
Owner

Oksydan commented Oct 10, 2022

Hi @Kandax86,

problem has been fixed.
New version of is_themecore will be released with 3.0.0 version of starter.

@Oksydan
Copy link
Owner

Oksydan commented Nov 24, 2022

New version has been released.
I am closing this issue.

@Oksydan Oksydan closed this as completed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants