Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when clicking on product in front office to view details #66

Closed
kennethbruyninckx opened this issue Jan 3, 2022 · 4 comments
Closed

Comments

@kennethbruyninckx
Copy link

PS 1.7.7.5 (which was the latest PS version around when I installed my webshop in July 2021, updating has always been a challange and a hit and miss for me... resulting in crashed and pretty unusable shops)
PHP 7.3.29
starter theme 1.3.0
is_imageslider-1.0.4
is_searchbar-1.0.0
is_shoppingcart-1.0.0
is_themecore-1.1.2

The theme was installed on a test copy of my live webshop installed in July 2021.
When I click on a products picture to see more details in front office I get the following:

image

@kennethbruyninckx
Copy link
Author

Another test copy of my shop was painstakingly (manually) upgraded to 1.7.8.2 and Starter theme v2.0.2 was installed on there with similar results as I click on a products picture to view more details:

image

@Oksydan
Copy link
Owner

Oksydan commented Jan 13, 2022

Hi @kennethbruyninckx,
I am really sorry that it took me too long to response, I am really busy recently.
Problem might be related to php version 7.4 and it will be fixed with is_themecore version 2.0 (huge update complete module refacto.

You should be able to fix it be replacing this line

if ($product['show_condition'] && $product['condition']) {

with

if (!empty($product['show_condition']) && !empty($product['condition'])) {

@caovillanueva
Copy link

i could fix this issue replacing the follow lines:

`` $conditions[$product['condition']]

with:

$product['condition']['type']

All the conditional should be something like :

if ($product['show_condition'] && $product['condition']) {
$jsonData['offers'] = array_merge($jsonData['offers'], [
'itemCondition' => $conditions[$product['condition']['type']]
]);
}

@Oksydan
Copy link
Owner

Oksydan commented May 7, 2022

Problems has been resolved on 2.0.0 is_themecore branch and it will be released soon with new version of theme.

@Oksydan Oksydan closed this as completed May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants