Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add on blur for radio and checkbox OKTA-670768 #2049

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

shuowu-okta
Copy link
Contributor

@shuowu-okta shuowu-okta commented Nov 29, 2023

OKTA-670768

Summary

Adds onBlur prop to Radio and Checkbox component

Testing & Screenshots

onBlur event is captured in storybook
Screenshot 2023-11-29 at 2 10 11 PM

  • I have confirmed this change with my designer and the Odyssey Design Team.

Copy link
Contributor

@chrispulsinelli-okta chrispulsinelli-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but there seems to be some issues with callbacks and missing dependencies.

Can we add tests for the stories to make sure blur is set / removed on the components?

@trevoring-okta
Copy link
Contributor

LGTM from a SIW POV, thanks Shuo! Ideally test by linking locally to SIW like we discussed via Slack

@shuowu-okta shuowu-okta force-pushed the sw-add-onBlur-for-Radio-and-Checkbox-OKTA-670768 branch from 042f84b to 3cbbe87 Compare December 1, 2023 18:39
@shuowu-okta shuowu-okta force-pushed the sw-add-onBlur-for-Radio-and-Checkbox-OKTA-670768 branch from 3cbbe87 to 187e42e Compare December 1, 2023 21:42
@shuowu-okta shuowu-okta merged commit a08fe5d into main Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants