Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post 4.9.0 update, refresh token not being rotated in local storage on tokenManager.renew() #747

Closed
Tennyx opened this issue May 20, 2021 · 3 comments

Comments

@Tennyx
Copy link

Tennyx commented May 20, 2021

It looks like with this fix: #656

It may have broken the refresh token being replaced in local storage at authClient.tokenManager.renew(token).

New refresh tokens are coming back on /token response, but not being saved in local storage. I tried the following:

authClient.tokenManager.renew('accessToken')
authClient.tokenManager.renew('accessToken', 'refreshToken)
authClient.tokenManager.renew('refreshToken')

Reverting to 4.8.0, it seems refresh token is updating in local storage with:

authClient.tokenManager.renew('accessToken')

@laura-rodriguez
Copy link

Hi @Tennyx ,

Thanks for reporting this issue. Our JS devs will review it soon and post updates here.

Internal Ref: https://oktainc.atlassian.net/browse/OKTA-397735

@cmacdonnacha
Copy link

Hey there, any idea when this might be fixed? I am currently reliant on version 4.9 so can't downgrade.

@aarongranick-okta
Copy link
Contributor

This issue has been fixed in okta-auth-js version 5.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants