Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Wrong type for LogEvent.DebugContext.DebugData in v4.0.0 #449

Open
FeignedHydra0 opened this issue Apr 8, 2024 · 14 comments
Open

Bug: Wrong type for LogEvent.DebugContext.DebugData in v4.0.0 #449

FeignedHydra0 opened this issue Apr 8, 2024 · 14 comments
Labels
bug Something isn't working Triaged

Comments

@FeignedHydra0
Copy link

Describe the bug?

I believe the DebugContext.DebugData type should be map[string]interface{} instead map[string]map[string]interface{}, see https://github.com/okta/okta-sdk-golang/blob/v4.0.0/okta/model_log_event.go#L37 and https://github.com/okta/okta-sdk-golang/blob/v4.0.0/okta/model_log_debug_context.go#L33

As a result JSON decoding of LogeEvent fails with cannot unmarshal string into Go struct field _LogEvent.debugContext of type map[string]interface {}

What is expected to happen?

listing system logs should succeed

What is the actual behavior?

listing system logs fails

Reproduction Steps?

Use the ListLogEventsExecute API

Additional Information?

example response should contain an object like seen here https://developer.okta.com/docs/reference/api/system-log/#logevent-object-annotated-example

Golang Version

go version go1.22.1 darwin/arm64

SDK Version

v4.0.0

OS version

Darwin ******* 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:10:42 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6000 arm64

@FeignedHydra0 FeignedHydra0 added the bug Something isn't working label Apr 8, 2024
@FeignedHydra0
Copy link
Author

This is preventing us currently from migrating to v4

@FeignedHydra0
Copy link
Author

@duytiennguyen-okta this could be related to or similar to #447

@duytiennguyen-okta
Copy link
Contributor

@FeignedHydra0 most probably

@duytiennguyen-okta
Copy link
Contributor

OKTA internal reference https://oktainc.atlassian.net/browse/OKTA-718064

@FeignedHydra0
Copy link
Author

@duytiennguyen-okta Do you perhaps Have a timeline I can give my management on when this fix will be ready? Just looking for visibility.

@duytiennguyen-okta
Copy link
Contributor

I am aiming to release on the week of April 22nd

Copy link

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Apr 27, 2024
@erezrokah
Copy link

Not stale

@github-actions github-actions bot removed the stale label Apr 28, 2024
@FeignedHydra0
Copy link
Author

FeignedHydra0 commented Apr 29, 2024

@duytiennguyen-okta just wanted to see if we can get a quick update on this one? I need to just provide on to Our leadership, on when we can migrate to v4?

@erezrokah
Copy link

Hi @FeignedHydra0 I'm not an maintainer so nothing much I can do. We're using a fork of this repo with the fix from #448 until this thing is sorted for all types

@duytiennguyen-okta
Copy link
Contributor

I will try to provide a release next week

@duytiennguyen-okta
Copy link
Contributor

I mean if you want to migrate, you can do it piece by piece and not the whole thing. You can import both v2 and v4 in the same go.mod file

@FeignedHydra0
Copy link
Author

We have v2 currently. But we can't migrate to v4 since this is what we are using currently.

@erezrokah
Copy link

Hi @duytiennguyen-okta it can be quite hard using both since it's hard to identify which v4 APIs have the wrong type and thus will break during runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Triaged
Projects
None yet
Development

No branches or pull requests

3 participants