HttpResponse not closed on Exception.

[gantzm]

In the following code, JsonApiClient.java:

  @Override
    protected  <T> T unmarshall(HttpResponse response, TypeReference<T> clazz) throws IOException {
        if (response.getEntity() == null || clazz.getType().equals(Void.class)) {
            EntityUtils.consume(response.getEntity());
            return null;
        }
        InputStream inputStream = response.getEntity().getContent();
        JsonParser parser = objectMapper.getFactory().createParser(inputStream);
        T toReturn = parser.readValueAs(clazz);
        EntityUtils.consume(response.getEntity());
        return toReturn;
    }

The response is not properly consumed if "parser.readValueAs(clazz)" throws an exception.

The EntityUtils.consume call should be placed in a finally block.

[bdemers]

No longer a problem in the current version