Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncio should not put under requirements.txt #157

Closed
RyanSiu1995 opened this issue Dec 14, 2020 · 4 comments
Closed

asyncio should not put under requirements.txt #157

RyanSiu1995 opened this issue Dec 14, 2020 · 4 comments

Comments

@RyanSiu1995
Copy link
Contributor

Hi community,
I am now using python 3.7+ with pip-compile.
And I will get error with asyncio if I installed it from pip.
From the doc in asyncio,

asyncio requires Python 3.3 or later! The asyncio module is part of the Python standard library since Python 3.4.

And also,

This version is only relevant for Python 3.3, which does not include asyncio in its stdlib.

So, my suggestion here is to remove the asyncio and release the okta package with 3.3+ only.
Thank you!

@serhiibuniak-okta
Copy link
Contributor

Hi @RyanSiu1995 , thank you for this issue and PR, currently we're on discussion on this here - #149. I believe, we will cover it with the first PR, will keep you posted.

@RyanSiu1995
Copy link
Contributor Author

Hi @sergiishamrai-okta, I don't see the update in the #149. Maybe you can first check out #158 and merge it to master.
It is a simple removal in the asyncio. Then, #149 can be rebased from the change in #158.

@serhiibuniak-okta
Copy link
Contributor

Hi @RyanSiu1995 , I've included both commits into one and just merged to master - #159. Need to wait until we can release v1.2.2. Thanks for your contribution.

@serhiibuniak-okta
Copy link
Contributor

@RyanSiu1995 we decided to include some additional changes, so we released v1.3.0. It is ready. I'm closing this issue as resolved. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants