Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Req: Add support for dynamic IdP routing rules #1531

Open
sgal-dm opened this issue Apr 18, 2023 · 7 comments · May be fixed by #1822
Open

Feature Req: Add support for dynamic IdP routing rules #1531

sgal-dm opened this issue Apr 18, 2023 · 7 comments · May be fixed by #1822
Assignees
Labels
enhancement Asking for new behavior or feature triaged Triaged into internal Jira

Comments

@sgal-dm
Copy link

sgal-dm commented Apr 18, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add support for dynamic IdP routing rules.
The existing behavior is the provider can only manage specific IdP routing rules, it doesn't appear to monitor the API attributes involved in specifying specific vs dynamic, as a rule can be manually changed to dynamic in the admin console without those changes showing up on plan/apply operations.

New or Affected Resource(s)

  • okta_policy_rule_idp_discovery
    • Potential New Attributes:
      • selection_type
        • string with a default value of SPECIFIC so existing code for specific rules is unaffected.
        • Maps to actions.idp.idpSelectionType in the API data structure.
      • provider_expression
        • string with a default value of null.
        • Maps to actions.idp.matchCriteria.providerExpression in the API data structure.

Potential Terraform Configuration

data "okta_policy" "idp_discovery_policy" {
  name = "Idp Discovery Policy"
  type = "IDP_DISCOVERY"
}

resource "okta_policy_rule_idp_discovery" "example" {
  policy_id                 = data.okta_policy.idp_discovery_policy.id
  name                      = "Select IdP by login domain"
  selection_type            = "DYNAMIC"
  provider_expression       = "login.identifier.substringAfter('@')" 
  network_connection        = "ANYWHERE"
  priority                  = 1
  status                    = "ACTIVE"
  user_identifier_type      = "ATTRIBUTE"
  user_identifier_attribute = "company"
  user_identifier_patterns {
    match_type = "EQUALS"
    value      = "ACME"
  }

References

@sgal-dm sgal-dm added the enhancement Asking for new behavior or feature label Apr 18, 2023
@monde
Copy link
Collaborator

monde commented Apr 18, 2023

Thanks @sgal-dm . We'll have to investigate and prioritize this onto our 4.1 and/or 5.0 release plans.
Okta internal reference: https://oktainc.atlassian.net/browse/OKTA-601942

@monde monde added the triaged Triaged into internal Jira label Apr 18, 2023
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label Jun 18, 2023
@sgal-dm
Copy link
Author

sgal-dm commented Jun 20, 2023

Not stale.

@github-actions github-actions bot removed the stale label Jun 21, 2023
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label Aug 21, 2023
@sgal-dm
Copy link
Author

sgal-dm commented Aug 21, 2023

Not stale

@github-actions github-actions bot removed the stale label Aug 22, 2023
@duytiennguyen-okta duytiennguyen-okta self-assigned this Nov 10, 2023
@duytiennguyen-okta duytiennguyen-okta linked a pull request Nov 20, 2023 that will close this issue
@duytiennguyen-okta
Copy link
Contributor

duytiennguyen-okta commented Nov 22, 2023

@sgal-dm I have the PR ready but it will be a breaking change so it will have to wait for v5

@sgal-dm
Copy link
Author

sgal-dm commented Nov 22, 2023

Awesome thanks for the update and the work @duytiennguyen-okta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Asking for new behavior or feature triaged Triaged into internal Jira
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants