Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Laravel Vue post to use CLI for setup #679

Merged
merged 14 commits into from
Apr 20, 2021
Merged

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Apr 3, 2021

@netlify
Copy link

netlify bot commented Apr 3, 2021

Deploy preview for okta-blog ready!

Built with commit 26ab149

https://deploy-preview-679--okta-blog.netlify.app

@mraible mraible added the qa-needed This blog post is ready for QA label Apr 3, 2021
@aaronpk
Copy link
Member

aaronpk commented Apr 12, 2021

So these changes are fine, but this blog post isn't really functional right now because it doesn't pin the Laravel version and it relies on an old version of Laravel to get through the instructions. If the scope of this change is to just update the setup instructions it can be merged as is, but if we need to actually update the post so that it works today it'll be a lot more work.

@mraible
Copy link
Contributor Author

mraible commented Apr 12, 2021

Is it possible to just pin the version as part of the install? If so, that might be the best solution. Then, create a new assignment to create a similar one that uses the latest versions.

@aaronpk
Copy link
Member

aaronpk commented Apr 12, 2021

I had to look it up, but yes thankfully that is possible!

@mraible
Copy link
Contributor Author

mraible commented Apr 16, 2021

@aaronpk I updated the code and this post to use Okta Vue 3.1.0. I did this because I believe the previous version used did not support PKCE, which means the app that CLI creates wouldn't work. I did NOT QA, I just updated the code.

@aaronpk
Copy link
Member

aaronpk commented Apr 20, 2021

I had to pin a few more libraries to old versions, but everything installs now. Unfortunately it looks like some of the libraries are too old to work in PHP 7.4 so ultimately I wasn't able to get this to work. But at least it's less broken now than it was before.

@mraible mraible merged commit 824e869 into main Apr 20, 2021
@mraible mraible deleted the laravel-vue-update branch April 20, 2021 00:15
mraible pushed a commit to cavazosjoe/okta-blog that referenced this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa-needed This blog post is ready for QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants