Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation false positive when api_token is set via environment variable #147

Merged
merged 1 commit into from Oct 29, 2020
Merged

Conversation

jgeurts
Copy link
Contributor

@jgeurts jgeurts commented Jul 10, 2020

Terraform validate fails when api_token is not specified but OKTA_API_TOKEN environment variable is specified. This should fix validation in that case. If this is not the preferred method to fix that bug, please let me know and I'd be happy to alter the change accordingly!

Terraform validate fails when api_token is not specified but `OKTA_API_TOKEN` environment variable is specified.
@ghost ghost added the size/XS label Jul 10, 2020
@noinarisak
Copy link
Contributor

Thanks @jgeurts! After some conversation with my teammate, it makes more sense for it to be optional and also the org_name. Updating docs and more.

@noinarisak noinarisak self-assigned this Oct 29, 2020
@noinarisak noinarisak added the enhancement Asking for new behavior or feature label Oct 29, 2020
@noinarisak
Copy link
Contributor

Related to PR #208

@noinarisak noinarisak merged commit 9722657 into okta:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Asking for new behavior or feature size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants